Hi Sebastian,
Thank you for the patch.
On Tue, Feb 25, 2020 at 12:20:36AM +0100, Sebastian Reichel wrote:
The write buffers are not modified, so they can be constant.
Signed-off-by: Sebastian Reichel sebastian.reichel@collabora.com
Assuming this compiles :-),
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
drivers/gpu/drm/omapdrm/dss/dsi.c | 24 ++++++++++++------------ drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +++++----- 2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index bb2548d091ef..f01e0476296d 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -2601,11 +2601,11 @@ static inline void dsi_vc_write_long_payload(struct dsi_data *dsi, int channel, }
static int dsi_vc_send_long(struct dsi_data *dsi, int channel, u8 data_type,
u8 *data, u16 len, u8 ecc)
const u8 *data, u16 len, u8 ecc){ /*u32 val; */ int i;
- u8 *p;
- const u8 *p; int r = 0; u8 b1, b2, b3, b4;
@@ -2698,7 +2698,7 @@ static int dsi_vc_send_null(struct dsi_data *dsi, int channel) }
static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel,
u8 *data, int len,
const u8 *data, int len, enum dss_dsi_content_type type){ int r; @@ -2729,7 +2729,7 @@ static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel, }
static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel,
u8 *data, int len)
const u8 *data, int len){ struct dsi_data *dsi = to_dsi_data(dssdev);
@@ -2738,7 +2738,7 @@ static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel, }
static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int channel,
u8 *data, int len)
const u8 *data, int len){ struct dsi_data *dsi = to_dsi_data(dssdev);
@@ -2747,7 +2747,7 @@ static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int chann }
static int dsi_vc_write_common(struct omap_dss_device *dssdev,
int channel, u8 *data, int len,
int channel, const u8 *data, int len, enum dss_dsi_content_type type){ struct dsi_data *dsi = to_dsi_data(dssdev); @@ -2776,15 +2776,15 @@ static int dsi_vc_write_common(struct omap_dss_device *dssdev, return r; }
-static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel, u8 *data,
int len)+static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel,
const u8 *data, int len){ return dsi_vc_write_common(dssdev, channel, data, len, DSS_DSI_CONTENT_DCS); }
-static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel, u8 *data,
int len)+static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel,
const u8 *data, int len){ return dsi_vc_write_common(dssdev, channel, data, len, DSS_DSI_CONTENT_GENERIC); @@ -2810,7 +2810,7 @@ static int dsi_vc_dcs_send_read_request(struct dsi_data *dsi, int channel, }
static int dsi_vc_generic_send_read_request(struct dsi_data *dsi, int channel,
u8 *reqdata, int reqlen)
const u8 *reqdata, int reqlen){ u16 data; u8 data_type; @@ -2983,7 +2983,7 @@ static int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int channel, u8 dcs_c }
static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int channel,
u8 *reqdata, int reqlen, u8 *buf, int buflen)
const u8 *reqdata, int reqlen, u8 *buf, int buflen){ struct dsi_data *dsi = to_dsi_data(dssdev); int r; diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 53fea1cbbc2d..b909b3a8c835 100644 --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h @@ -308,18 +308,18 @@ struct omapdss_dsi_ops {
/* data transfer */ int (*dcs_write)(struct omap_dss_device *dssdev, int channel,
u8 *data, int len);
const u8 *data, int len);
u8 *data, int len);
const u8 *data, int len);int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd, u8 *data, int len);
int (*gen_write)(struct omap_dss_device *dssdev, int channel,
u8 *data, int len);
const u8 *data, int len);
u8 *data, int len);
const u8 *data, int len);
u8 *reqdata, int reqlen,
const u8 *reqdata, int reqlen, u8 *data, int len);int (*bta_sync)(struct omap_dss_device *dssdev, int channel);