On Thu, Dec 10, 2015 at 06:11:39PM +0530, Archit Taneja wrote:
A driver calling mipi_dsi_device_new might want to unregister the device once it's done. It might also require it in an error handling path in case something didn't go right.
Reviewed-by: Andrzej Hajda a.hajda@samsung.com Signed-off-by: Archit Taneja architt@codeaurora.org
include/drm/drm_mipi_dsi.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index cb084af..410d8b5 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -195,6 +195,11 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host, struct mipi_dsi_device_info *info); +static inline void mipi_dsi_device_unregister(struct mipi_dsi_device *dsi) +{
- device_unregister(&dsi->dev);
+}
This is the same, essentially, as mipi_dsi_remove_device_fn(). I think this should move into drm_mipi_dsi.c and mipi_dsi_remove_device_fn() should call this new function so that both OF and !OF share the same code for this.
Thierry