Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support

Hi Guido,

On Wed, Jul 31, 2019 at 11:35 AM Guido Günther agx@sigxcpu.org wrote:

The idea is to have

"%sabling platform clocks", enable ? "en" : "dis");

depending whether clocks are enabled/disabled.

Yes, I understood the idea, but this would print:

ensabling or dissabling :-)

...

Same here. Please return 'int' instead.

This is from drm_bridge_funcs so the prototype is fixed. I'm not sure how what's the best way to bubble up fatal errors through the drm layer?

Ok, so let's not change this one.

I went for DRM_DEV_ERROR() since that what i used in the rest of the driver and these ones were omission. Hope that's o.k.

No strong preferences here. I just think dev_err() easier to type and shorter.

Thanks for this work!