Re: [PATCH] kernel/drm: vblank wait on crtc > 1

On Fre, 2011-03-18 at 16:58 -0500, Ilija Hadzic wrote:

This patch extends the interface to drm_wait_vblank ioctl so that crtc>1 can be represented. It also adds a new capability to drm_getcap ioctl so that the user space can check whether the new interface to drm_wait_vblank is supported (and fall back to the legacy interface if not)

[...]

You seem to have silently ignored my previous concerns and suggestions about the handling of the high CRTC mask/shift.

@@ -753,6 +755,7 @@ struct drm_event_vblank { };

#define DRM_CAP_DUMB_BUFFER 0x1 +#define DRM_CAP_HIGH_CRTC 0x2

Seems like a rather generic name, something like DRM_CAP_VBLANK_HIGH_CRTC might be better.