On Wed, 14 Jul 2021 at 21:45, Jason Ekstrand jason@jlekstrand.net wrote:
We don't roll them together entirely because there are still a couple cases where we want a separate can_migrate check. For instance, the display code checks that you can migrate a buffer to LMEM before it accepts it in fb_create. The dma-buf import code also uses it to do an early check and return a different error code if someone tries to attach a LMEM-only dma-buf to another driver.
However, no one actually wants to call object_migrate when can_migrate has failed. The stated intention is for self-tests but none of those actually take advantage of this unsafe migration.
Signed-off-by: Jason Ekstrand jason@jlekstrand.net Cc: Daniel Vetter daniel@ffwll.ch Cc: Matthew Auld matthew.auld@intel.com
Reviewed-by: Matthew Auld matthew.auld@intel.com