On 3/17/22 02:04, Dmitry Osipenko wrote:
On 3/16/22 18:04, Steven Price wrote:
On 14/03/2022 22:42, Dmitry Osipenko wrote:
Replace Panfrost's memory shrinker with a generic DRM memory shrinker.
Signed-off-by: Dmitry Osipenko dmitry.osipenko@collabora.com
I gave this a spin on my Firefly-RK3288 board and everything seems to work. So feel free to add a:
Tested-by: Steven Price steven.price@arm.com
As Alyssa has already pointed out you need to remove the panfrost_gem_shrinker.c file. But otherwise everything looks fine, and I'm very happy to see the shrinker code gone ;)
Awesome, thank you.
Steven, could you please tell me how exactly you tested the shrinker?
I realized that today's IGT doesn't have any tests for the Panfrost's madvise ioctl.
You may invoke "echo 2 > /proc/sys/vm/drop_caches" manually in order to trigger shrinker while 3d app is running actively (like a game or benchmark). Nothing crashing will be a good enough indicator that it works okay.
I may get an RK board next week and then will be able to test it by myself, so please don't hurry.