Re: [PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

On Fri, 11 Oct 2019 15:54:53 +0200 Andrzej Hajda a.hajda@samsung.com wrote:

On 26.08.2019 17:26, Boris Brezillon wrote:

...

The encoder->enable() can't report errors and is expected to always succeed. If we call pm_runtime_put() in the exynos_dsi_enable() error path (as currently done) we'll have unbalanced get/put calls when encoder->disable() is called.

True

I just realized this is actually not the case, because the DSIM_STATE_ENABLED flag is cleared in the error path, and exynos_dsi_disable() bails out early when DSIM_STATE_ENABLED is not set.