Hi Marek,
Thank you for the patch.
On Fri, Apr 01, 2022 at 06:37:55PM +0200, Marek Vasut wrote:
The of_get_drm_panel_display_mode() now does check for presence of width-mm/height-mm DT properties, drop the duplicate check here.
Signed-off-by: Marek Vasut marex@denx.de Cc: Christoph Niedermaier cniedermaier@dh-electronics.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Dmitry Osipenko digetx@gmail.com Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Noralf Trønnes noralf@tronnes.org Cc: Rob Herring robh+dt@kernel.org Cc: Robert Foss robert.foss@linaro.org Cc: Sam Ravnborg sam@ravnborg.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: devicetree@vger.kernel.org To: dri-devel@lists.freedesktop.org
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
assuming patches 1/3 and 2/3 get accepted.
drivers/gpu/drm/panel/panel-lvds.c | 12 ------------ 1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index eca067e78579..f11252fb00fe 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -128,18 +128,6 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) return ret; }
if (lvds->dmode.width_mm == 0) {
dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n",
np, "width-mm");
return -ENODEV;
}
if (lvds->dmode.height_mm == 0) {
dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n",
np, "height-mm");
return -ENODEV;
}
of_property_read_string(np, "label", &lvds->label);
ret = drm_of_lvds_get_data_mapping(np);