On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel paulepanter@users.sourceforge.net wrote:
Dear Chen,
thanks for your patch.
Firstly, is Chen your first or last name? If it is your first name, your From address should be switched.
Chen is may last name.
Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
When SWIOTLB is configured, if without this patch kernel compilation fails.
Secondly, could you please always paste part of the error message into the commit message so that people hitting this problem and searching for it on the WWW have a higher chance finding your patch.
OK, I'll paste error message.
Thirdly, do you know why this was not caught beforehand and compilation worked before?
Maybe radeon is mostly used on X86 and swiotlb.h is included indirectly on X86 platform. This patch is split from my MIPS patchset, on MIPS machines compilation always failed.
Signed-off-by: Huacai Chen chenhc@lemote.com
Lastly, the addresses in your From line and Signed-off-by line disagree. You can easily fix that, by adding
My patch is generated by git format-patch and there is surely a From line in the beginning (from chenhc@lemote.com), but the mail is sent out by gmail, so I don't know how to make From line and Signed-off-by agree.
From: Huacai Chen <chenhc@lemote.com>to the beginning of your message.
Signed-off-by: Hongliang Tao taohl@lemote.com Signed-off-by: Hua Yan yanh@lemote.com Cc: dri-devel@lists.freedesktop.org
drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 5b71c71..fc3ac22 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -41,6 +41,10 @@ #include "radeon_reg.h" #include "radeon.h"
+#ifdef CONFIG_SWIOTLB +#include <linux/swiotlb.h> +#endif
#define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
static int radeon_ttm_debugfs_init(struct radeon_device *rdev);
With the clarification above
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>can be added to your patch.
Thanks,
Paul