On Fri, Mar 20, 2020 at 02:46:09PM -0700, Ralph Campbell wrote:
On 3/20/20 9:49 AM, Jason Gunthorpe wrote:
From: Jason Gunthorpe jgg@mellanox.com
Delete several functions that are never called, fix some desync between comments and structure content, remove an unused ret, and move one function only used by hmm.c into hmm.c
Signed-off-by: Jason Gunthorpe jgg@mellanox.com
Reviewed-by: Ralph Campbell rcampbell@nvidia.com
include/linux/hmm.h | 50 --------------------------------------------- mm/hmm.c | 12 +++++++++++ 2 files changed, 12 insertions(+), 50 deletions(-)
diff --git a/include/linux/hmm.h b/include/linux/hmm.h index bb6be4428633a8..184a8633260f9d 100644 +++ b/include/linux/hmm.h @@ -120,9 +120,6 @@ enum hmm_pfn_value_e {
- @notifier: a mmu_interval_notifier that includes the start/end
- @notifier_seq: result of mmu_interval_read_begin()
- @hmm: the core HMM structure this range is active against
- @vma: the vm area struct for the range
- @list: all range lock are on a list
- @start: range virtual start address (inclusive)
- @end: range virtual end address (exclusive)
- @pfns: array of pfns (big enough for the range)
@@ -131,7 +128,6 @@ enum hmm_pfn_value_e {
- @default_flags: default flags for the range (write, read, ... see hmm doc)
- @pfn_flags_mask: allows to mask pfn flags so that only default_flags matter
- @pfn_shifts: pfn shift value (should be <= PAGE_SHIFT)
s/pfn_shifts/pfn_shift
Got it in v2, thanks
Jason