Hi Laurent,
On Mon, 2022-01-24 at 00:15 +0200, Laurent Pinchart wrote:
Hi Liu,
Thank you for the patch.
Thank you for your review.
On Wed, Jan 19, 2022 at 10:37:14AM +0800, Liu Ying wrote:
The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy mentions that it should be in UI. However, the dphy core driver wrongly sets 'clk_pre' to 8000, which seems to hint that it's in picoseconds. And, the kernel doc of the 'clk_pre' member wrongly says the minimum value is '8 UI', instead of 8.
I'm not sure I'd change the kernel doc. Other fields that are documented as "Time, in picoseconds" have min/max values expressed in ps, so clk_pre, documented as "Time, in UI" doesn't appear wrong if the minimum value is "8 UI".
Otherwise, this patch looks fine to me. With or without dropping that documentation change,
I'll drop the documentation change in v3.
Regards, Liu Ying
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com