Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote:

This patch removes the write and force parameters from get_user_pages_locked() and replaces them with a gup_flags parameter to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem.

Signed-off-by: Lorenzo Stoakes lstoakes@gmail.com

After our discussion the patch looks good to me. You can add:

Reviewed-by: Jan Kara jack@suse.cz

Honza