Hi Rob,
Thank you for the review.
On 03 January, 2017 23:51 CET, Rob Herring robh@kernel.org wrote:
On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote:
Devicetree bindings documentation for the GE B850v3 LVDS/DP++ display bridge.
Cc: Martyn Welch martyn.welch@collabora.co.uk Cc: Martin Donnelly martin.donnelly@ge.com Cc: Javier Martinez Canillas javier@dowhile0.org Cc: Enric Balletbo i Serra enric.balletbo@collabora.com Cc: Philipp Zabel p.zabel@pengutronix.de Cc: Rob Herring robh@kernel.org Cc: Fabio Estevam fabio.estevam@nxp.com Signed-off-by: Peter Senna Tschudin peter.senna@collabora.com
There was an Acked-by from Rob Herring robh@kernel.org for V6, but I changed the bindings to use i2c_new_secondary_device() so I removed it from the commit message.
.../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++
Generally, bindings are not organized by vendor. Put in bindings/display/bridge/... instead.
Will change that.
1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt new file mode 100644 index 0000000..1bc6ebf --- /dev/null +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt @@ -0,0 +1,39 @@ +Driver for GE B850v3 LVDS/DP++ display bridge
+Required properties:
- compatible : should be "ge,b850v3-lvds-dp".
Isn't '-lvds-dp' redundant? The part# should be enough.
b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output?
- reg : should contain the main address which is used to ack the
- interrupts and address for edid.
- reg-names : comma separeted list of register names. Valid values
s/separeted/separated/
argh, sorry for this. Will fix it.
- are "main", and "edid".
- interrupt-parent : phandle of the interrupt controller that services
- interrupts to the device
- interrupts : one interrupt should be described here, as in
- <0 IRQ_TYPE_LEVEL_HIGH>.
- port : should describe the video signal connection between the host
- and the bridge.
+Example:
+&mux2_i2c2 {
- status = "okay";
- clock-frequency = <100000>;
- b850v3-lvds-dp-bridge@73 {
compatible = "ge,b850v3-lvds-dp";#address-cells = <1>;#size-cells = <0>;reg = <0x73 0x72>;reg-names = "main", "edid";interrupt-parent = <&gpio2>;interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;port {b850v3_dp_bridge_in: endpoint {remote-endpoint = <&lvds0_out>;};};- };
+};
2.5.5