Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime.

Eric Anholt eric@anholt.net writes:

For the Raspberry Pi's bindings, the power domain also implicitly turns on the clock and deasserts reset, but for the new Cygnus port we start representing the clock in the devicetree.

• v3d->clk = devm_clk_get(dev, "v3d_clk");
• if (IS_ERR(v3d->clk)) {

• int ret = PTR_ERR(v3d->clk);
  

• if (ret == -ENODEV) {
  

Apparently I hadn't booted this on RPi yet. This is supposed to be -ENOENT.

• 	/* bcm2835 didn't have a clock reference in the DT. */
  

• 	ret = 0;
  

• 	v3d->clk = NULL;
  

• } else {
  

• 	if (ret != -EPROBE_DEFER)
  

• 		dev_err(dev, "Failed to get V3D clock: %d\n",
  

• 			ret);
  

• 	return ret;
  

• }
  

• }