Re: [PATCH 2/2] drm: Serialise multiple event readers

On Thu, Nov 26, 2015 at 12:19:43PM +0100, Thomas Hellstrom wrote:

On 11/25/2015 03:56 PM, Chris Wilson wrote:

...

On Wed, Nov 25, 2015 at 03:44:04PM +0100, Thomas Hellstrom wrote:

...

Do you need to take the mutex around other event pullers as well?

We would. I checked in drm/*.c for other users, but not the drivers. A quick git grep doesn't show any likely candidates, they appear to be private event lists.

Indeed. I was confused by some exynos code I didn't look at too carefully. Also vmwgfx has some code to pull events, but it is not called until release time so it can't race.

So for the series: Reviewed-by: Thomas Hellstrom thellstrom@vmware.com

Thanks for patches&review, applied to drm-misc. -Daniel