Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote: [...]

diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 88a3558..a9ec99d 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -314,6 +314,13 @@ static int host1x_device_match(struct device *dev, struct device_driver *drv) return strcmp(dev_name(dev), drv->name) == 0; }

+static int host1x_dma_configure(struct device *dev) +{

• if (dev->of_node)

• return of_dma_configure(dev, dev->of_node);
  

The conditional here is somewhat pointless since the of_node should always be set. If it weren't it should be considered a bug and this function welcome to crash to make that very obvious.

Either way:

Acked-by: Thierry Reding treding@nvidia.com