Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

On 01 January, 2017 21:24 CET, Peter Senna Tschudin peter.senna@collabora.com wrote:

[ ... ]

+static void ge_b850v3_lvds_dp_detach(struct drm_bridge *bridge) +{

• struct ge_b850v3_lvds_dp *ptn_bridge

• 	= bridge_to_ge_b850v3_lvds_dp(bridge);
  

• struct i2c_client *ge_b850v3_lvds_dp_i2c

• 	= ptn_bridge->ge_b850v3_lvds_dp_i2c;
  

• /* Disable interrupts */
• i2c_smbus_write_word_data(ge_b850v3_lvds_dp_i2c,

• 	STDP4028_DPTX_IRQ_EN_REG, ~STDP4028_DPTX_IRQ_CONFIG);
  

~STDP4028_DPTX_IRQ_CONFIG? Argh! Will fix this and resend after reviews...

[ ... ]