Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

On 8/7/19 10:42 PM, Michael Ellerman wrote:

Hi John,

john.hubbard@gmail.com writes:

...

diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c index b056cae3388b..e126193ba295 100644 --- a/arch/powerpc/mm/book3s64/iommu_api.c +++ b/arch/powerpc/mm/book3s64/iommu_api.c @@ -203,6 +202,7 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) { long i; struct page *page = NULL;

• bool dirty = false;

I don't think you need that initialisation do you?

Nope, it can go. Fixed locally, thanks.

Did you get a chance to look at enough of the other bits to feel comfortable with the patch, overall?

thanks,