Re: [PATCH] drm/msm/a6xx: restore previous freq on resume

Quoting Rob Clark (2019-11-18 15:40:38)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h index 39a26dd63674..2af91ed7ed0c 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h @@ -63,6 +63,9 @@ struct a6xx_gmu { struct clk_bulk_data *clocks; struct clk *core_clk;

•   /* current performance index set externally */
  

•   int current_perf_index;
  

Is there a reason this isn't unsigned? It looks like __a6xx_gmu_set_freq() takes an int, but maybe it should take a u16 or something?