Re: [PATCH 15/21] drm: mxsfb: Remove mxsfb_devdata unused fields

On 2020-03-09 20:52, Laurent Pinchart wrote:

The debug0 and ipversion fields of the mxsfb_devdata structure are unused. Remove them.

Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

Reviewed-by: Stefan Agner stefan@agner.ch

---

drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ---- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 -- 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 72b4f6a947a4..7c9a041f5f6d 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -42,19 +42,15 @@ static const struct mxsfb_devdata mxsfb_devdata[] = { .transfer_count = LCDC_V3_TRANSFER_COUNT, .cur_buf = LCDC_V3_CUR_BUF, .next_buf = LCDC_V3_NEXT_BUF,

• .debug0		= LCDC_V3_DEBUG0,
  

  .hs_wdth_mask = 0xff, .hs_wdth_shift = 24,

• .ipversion	= 3,
  

  }, [MXSFB_V4] = { .transfer_count = LCDC_V4_TRANSFER_COUNT, .cur_buf = LCDC_V4_CUR_BUF, .next_buf = LCDC_V4_NEXT_BUF,

• .debug0		= LCDC_V4_DEBUG0,
  

  .hs_wdth_mask = 0x3fff, .hs_wdth_shift = 18,

• .ipversion	= 4,
  

  },

};

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h b/drivers/gpu/drm/mxsfb/mxsfb_drv.h index edd766ad254f..607a6a5e6be3 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.h +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.h @@ -19,10 +19,8 @@ struct mxsfb_devdata { unsigned int transfer_count; unsigned int cur_buf; unsigned int next_buf;

• unsigned int debug0; unsigned int hs_wdth_mask; unsigned int hs_wdth_shift;
• unsigned int ipversion;

};

struct mxsfb_drm_private {