Hi Russell,
On 09/06/17 16:10, Russell King - ARM Linux wrote:
On Fri, Jun 09, 2017 at 03:56:39PM +0200, Neil Armstrong wrote:
Yes, but on the Amlogic Meson plarform, the DW-HDMI CEC controller is not used, but a custom one, so this notifier is actually useful for this platform and maybe others.
Is the CEC controller configured into dw-hdmi (is the config bit set?) I'm just wondering if we're going to end up with two CEC drivers trying to bind to the same notifier.
Should we really wait until I push the Amlogic AO CEC driver ? Having a notifier in the DW-HDMI driver won't harm anybody since it *will be used*.
It sounds like this adds additional information that has been missing from the review of my patches - and I suspect changes Hans' comments. So, I'll wait, it seems pointless to try and update the patches when it's not clear how to proceed due to other dependencies, especially when it means that their existing state is what's required (I'm pleased that I've held off modifying the patches so far.)
If that means having to wait another kernel revision, then I guess that's what will have to happen.
Can you respin your patch series, keeping the notifier support? The CEC kernel config handling has been cleaned up (just select CEC_CORE and CEC_NOTIFIER) so you should be good to go.
I've already Acked patches 1-3. I had some comments for patch 4, so that needs a bit more work.
Note that there is now a cec_transmit_attempt_done() helper function that will simplify your code.
Regards,
Hans