On Thu, Apr 11, 2013 at 08:17:42PM +0100, Chris Wilson wrote:
On Thu, Apr 11, 2013 at 08:22:50PM +0200, Daniel Vetter wrote:
It will be only consistent once we've restored all the crtcs. Since a bunch of other callers also want to just restore a single crtc, add a boolean to disable checking only where it doesn't make sense.
Note that intel_modeset_setup_hw_state already has a call to intel_modeset_check_state at the end, so we don't reduce the amount of checking.
v2: Try harder not to create a big patch (Chris).
v3: Even smaller (still Chris). Also fix a trailing space.
References: https://lkml.org/lkml/2013/3/16/60 Cc: Tomas Melin tomas.melin@iki.fi Cc: Richard Cochran richardcochran@gmail.com Cc: Chris Wilson chris@chris-wilson.co.uk Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch
I'm happy that you are not touching any paths other than mentioned in the changelog, and that I think being quiet on the modeset is a good use of the 'force' semantics, so
Reviewed-by: Chris Wilson chris@chris-wilson.co.uk
Queued for -next, thanks for the review. -Daniel