Hi Laurent, Jacopo,
On Thu, Jun 6, 2019 at 8:50 PM Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
On Thu, Jun 06, 2019 at 04:22:03PM +0200, Jacopo Mondi wrote:
Update the 'vsps' property structure in the documentation example to reflect what's actually implemented in the device tree sources.
Signed-off-by: Jacopo Mondi jacopo+renesas@jmondi.org
--- a/Documentation/devicetree/bindings/display/renesas,du.txt +++ b/Documentation/devicetree/bindings/display/renesas,du.txt @@ -92,7 +92,7 @@ Example: R8A7795 (R-Car H3) ES2.0 DU <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3";
vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
vsps = <&vspd0 0 &vspd1 0 &vspd2 &vspd0 1>;The former is simpler to read than the latter in my opinion. Shouldn't we update the .dtsi files instead ?
Yes, it is easier to read (for humans).
cmms = <&cmm0 &cmm1 &cmm2 &cmm3>;
Perhaps we want grouping here, too?
ports {
Gr{oetje,eeting}s,
Geert