Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback

Am 14.07.2017 um 21:44 schrieb Felix Kuehling:

On 17-07-14 06:08 AM, Christian König wrote:

...

Am 13.07.2017 um 23:08 schrieb Felix Kuehling: [SNIP]

...

•    result += bytes;
  

•    buf = (uint8_t *)buf + bytes;
  

•    pos += bytes;
  

•    len -= bytes;
  

•    if (pos >= (nodes->start + nodes->size) << PAGE_SHIFT) {
  

•        ++nodes;
  

•        pos = (nodes->start << PAGE_SHIFT);
  

... Here I handle crossing a node boundary. Yes, I actually added this case to my kfdtest unit test and made sure it works, along with all odd alignments that the code above handles.

Ah, I see. Sorry totally missed that chunk. In this case the patch is Acked-by: Christian König christian.koenig@amd.com

Regards, Christian.

Regards, Felix