Hi Lucas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.15-rc3 next-20210823] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lucas-De-Marchi/drm-i915-remove-IS_... base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-r024-20211001 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 962e503cc8bc411f7523cc393acae8aae425b1c4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/50006042f1d264599bd1be1942f9958112e1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Lucas-De-Marchi/drm-i915-remove-IS_ACTIVE/20211001-154226 git checkout 50006042f1d264599bd1be1942f9958112e15c01 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/i915_config.c:11:14: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
if (context && CONFIG_DRM_I915_FENCE_TIMEOUT) ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_config.c:11:14: note: use '&' for a bitwise operation if (context && CONFIG_DRM_I915_FENCE_TIMEOUT) ^~ & drivers/gpu/drm/i915/i915_config.c:11:14: note: remove constant to silence this warning if (context && CONFIG_DRM_I915_FENCE_TIMEOUT) ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
vim +11 drivers/gpu/drm/i915/i915_config.c
7 8 unsigned long 9 i915_fence_context_timeout(const struct drm_i915_private *i915, u64 context) 10 {
11 if (context && CONFIG_DRM_I915_FENCE_TIMEOUT)
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org