On Mon, May 11, 2020 at 4:53 AM Ira Weiny ira.weiny@intel.com wrote:
On Sat, May 09, 2020 at 12:01:31AM +0200, Arnd Bergmann wrote:
In order to call kmap_atomic() etc, we need to include linux/highmem.h:
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] 377 | kunmap_atomic(d->src_addr); | ^~~~~~~~~~~~~ | in_atomic drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration] 391 | kmap_atomic_prot(d->dst_pages[dst_page], | ^~~~~~~~~~~~~~~~ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 390 | d->dst_addr = | ^ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 403 | d->src_addr = | ^
Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code") Signed-off-by: Arnd Bergmann arnd@arndb.de
I'm curious about the config which failed... Because this compiled for me. Regardless it was stupid of me to not include this.
Thanks,
Reviewed-by: Ira Weiny ira.weiny@intel.com
I do a lot of randconfig build tests and only one of them had this problem.
See https://pastebin.com/LmX0Jfbg for reference, I did not check further which of the options caused this.
Arnd