On 2019/07/30, Noralf Trønnes wrote:
Den 30.07.2019 15.53, skrev Emil Velikov:
On 2019/07/25, Noralf Trønnes wrote:
This makes the tiny drivers visible by default without having to enable a knob.
Signed-off-by: Noralf Trønnes noralf@tronnes.org
drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++-------------- 2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 98c732f925c7..0b30afa7524d 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/ obj-y += hisilicon/ obj-$(CONFIG_DRM_ZTE) += zte/ obj-$(CONFIG_DRM_MXSFB) += mxsfb/ -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/ +obj-y += tinydrm/ obj-$(CONFIG_DRM_PL111) += pl111/ obj-$(CONFIG_DRM_TVE200) += tve200/ obj-$(CONFIG_DRM_XEN) += xen/ diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig index 42b06f4f8989..f8c9a0e71dde 100644 --- a/drivers/gpu/drm/tinydrm/Kconfig +++ b/drivers/gpu/drm/tinydrm/Kconfig @@ -1,16 +1,9 @@ # SPDX-License-Identifier: GPL-2.0-only -menuconfig DRM_TINYDRM
- tristate "Support for simple displays"
- depends on DRM
- select DRM_KMS_HELPER
- select DRM_KMS_CMA_HELPER
- help
Choose this option if you have a tinydrm supported display.If M is selected the module will be called tinydrm.Fwiw I would have gone with Han's idea of making this hidden. That has a number of advantages, even if we don't have a separate tinydrm.ko:
- the tinydrm code is not build when there are no users
The thing is, there is no tinydrm code anymore, it's all been put into various core helpers. The folder does only contain regular DRM drivers. The only thing special about them is that they fit into one source file.
Right, I saw your series killing tinydrm.ko [1] and missed see the mipi-dbi.c move with commit 174102f4de230a1bf85e6ef2f8c83e50b3ba22c9
Thanks for the awesome work. Emil