2015-07-09 Joonyoung Shim jy0922.shim@samsung.com:
+Cc Andrzej,
On 07/07/2015 02:41 AM, Daniel Vetter wrote:
On Mon, Jul 06, 2015 at 11:20:13AM -0300, Gustavo Padovan wrote:
From: Gustavo Padovan gustavo.padovan@collabora.co.uk
struct drm_crtc already stores the enabled state of the crtc thus we don't need to replicate enabled in exynos_drm_crtc.
I think exynos_crtc->enabled can replace flags for power state of each hw driver(e.g. "powered" of mixer driver, "suspended" of fimd driver). Further, we can add other flag bit for instead of using special flag in hw driver like vsync state("int_en" of mixer driver, "irq_flags" of fimd driver.)
The reason I removed it is because crtc->state->active already stores the same information as exynos_crtc->enabled. I think we could rely on active as well for mixer powered and suspended.
Gustavo