On Mon, Nov 3, 2014 at 4:27 AM, Thierry Reding thierry.reding@gmail.com wrote:
From: Thierry Reding treding@nvidia.com
The output is already enabled in .dpms(), doing it in .mode_set() too can cause noticeable flicker.
I think this should be coupled with "drm/tegra: DPMS off/on in encoder prepare/commit" that I sent earlier this week. Without it, the driver can get into a state where connector status is on, but the output is disabled.
Sean
Signed-off-by: Thierry Reding treding@nvidia.com
drivers/gpu/drm/tegra/output.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index 0c67d7eebc94..6b393cfbb5e7 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -167,12 +167,6 @@ static void tegra_encoder_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, struct drm_display_mode *adjusted) {
struct tegra_output *output = encoder_to_output(encoder);int err;err = tegra_output_enable(output);if (err < 0)dev_err(encoder->dev->dev, "tegra_output_enable(): %d\n", err);}
static const struct drm_encoder_helper_funcs encoder_helper_funcs = {
2.1.2