Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20201204] [also build test ERROR on v5.10-rc6] [cannot apply to tegra-drm/drm/tegra/for-next soc/for-next linus/master drm/drm-next v5.10-rc6 v5.10-rc5 v5.10-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/drivers-video-W-1-warn... base: 2996bd3f6ca9ea529b40c369a94b247657abdb4d config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9c4170037512dc3810cd88f57e3c3a442304... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sam-Ravnborg/drivers-video-W-1-warning-fixes/20201207-030414 git checkout 9c4170037512dc3810cd88f57e3c3a442304b7cf # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
In file included from include/linux/io.h:13, from include/linux/irq.h:20, from include/asm-generic/hardirq.h:17, from arch/sh/include/asm/hardirq.h:9, from include/linux/hardirq.h:10, from include/linux/interrupt.h:11, from drivers/net/ethernet/xircom/xirc2ps_cs.c:74: drivers/net/ethernet/xircom/xirc2ps_cs.c: In function 'xirc2ps_release':
arch/sh/include/asm/io.h:274:29: error: void value not ignored as it ought to be
274 | #define iounmap(addr) do { (void)addr; } while (0) drivers/net/ethernet/xircom/xirc2ps_cs.c:935:4: note: in expansion of macro 'iounmap' 935 | iounmap(local->dingo_ccr - 0x0800); | ^~~~~~~
vim +274 arch/sh/include/asm/io.h
272 273 #else /* CONFIG_MMU */
274 #define iounmap(addr) do { (void)addr; } while (0)
275 #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) 276 #endif /* CONFIG_MMU */ 277
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org