On 18 April 2017 at 11:32, Emil Velikov emil.l.velikov@gmail.com wrote:
On 17 April 2017 at 21:13, Robert Foss robert.foss@collabora.com wrote:
From: Sean Paul seanpaul@chromium.org
From drm_crtc.h, for use with the plane "rotation" property.
Please see the include/drm/README.
To elaborate a bit: The headers in include/drm should be synced via make headers_install + copy, as seen in git log and described in the README file.
Although for the properties here we seems to be in a pickle. These are defined in drm_blend.h which is not exported as part of the ABI. Yet the defines _are_ part of the ABI - see the lovely warning, which was added when someone broke and ABI and hence userspace.
My suggestion - fix this in the kernel first. - Move the DRM_ROTATE* and DRM_REFLECT_* to an ABI header. Having a slight preference about drm_mode.h but drm.h should also be fine. - Optional: skim through for other properties that should be moved to the ABI headers. - Update libdrm as described in the README (please send patches if the documentation is not clear)
Thanks Emil