On Tue, Mar 10, 2020 at 03:33:07PM +0100, Greg KH wrote:
On Tue, Mar 10, 2020 at 04:31:04PM +0300, Wambui Karuga wrote:
This series includes work on various debugfs functions both in drm/core and across various drivers in the subsystem. Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() does not fail and only returns zero. This series therefore removes the left over error handling and checks for its return value across drm drivers.
As a result of these changes, most drm_debugfs functions are converted to return void in this series. This also enables the drm_driver, debugfs_init() hook to be changed to return void.
v2: individual driver patches have been converted to have debugfs functions return 0 instead of void to prevent breaking individual driver builds. The last patch then converts the .debugfs_hook() and its users across all drivers to return void.
This looks much better to me, nice job:
Yup, really nice all!
Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
Thanks for the patches (and the review), everything queued up in drm-misc-next. But missed the 5.7 feature freeze in drm unfortunately, so heading for 5.8. Apologies for being a bit too distracted past week and not merging this a bit more timely. -Daniel