Hi John,
Feel free to submit a new patch.
Regards, Yongjun Wei
From: John Hunter [mailto:zhjwpku@gmail.com] Sent: 2015年4月22日 10:30 To: weiyj_lk@163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun Wei (RD-CN); intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; open list Subject: Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c
Hi,
I think maybe we should remove both of the two lines: #include "intel_drv.h" #include "i915_drv.h" Because we have two "intel_drv.h" and one "i915_drv.h", and "i915_drv.h" has already been included in the "intel_drv.h".
I not sure whether i am right. If you need me to do the patch, let me know.
On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter <daniel@ffwll.chmailto:daniel@ffwll.ch> wrote: On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk@163.commailto:weiyj_lk@163.com wrote:
From: Wei Yongjun <yongjun_wei@trendmicro.com.cnmailto:yongjun_wei@trendmicro.com.cn>
Remove duplicated include.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cnmailto:yongjun_wei@trendmicro.com.cn>
Queued for -next, thanks for the patch. -Daniel
drivers/gpu/drm/i915/intel_audio.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 2396cc7..d00d488 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -28,7 +28,6 @@
#include <drm/drmP.h> #include <drm/drm_edid.h> -#include "intel_drv.h" #include "i915_drv.h"
/**
Intel-gfx mailing list Intel-gfx@lists.freedesktop.orgmailto:Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.orgmailto:dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Best regards Junwang Zhao Microprocessor Research and Develop Center Department of Computer Science &Technology Peking University Beijing, 100871, PRC
=======================================================
This message has been analyzed by Deep Discovery Email Inspector.
<table class="TM_EMAIL_NOTICE"><tr><td><pre> TREND MICRO EMAIL NOTICE The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system. </pre></td></tr></table>