Hi Sean,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip next-20210916] [cannot apply to robh/for-next linus/master v5.15-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sean-Paul/drm-hdcp-Pull-HDCP-auth-e... base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-r033-20210916 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/eb031b7a8eac1f8c6f61fee94daa7fd43945... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sean-Paul/drm-hdcp-Pull-HDCP-auth-exchange-check-into-helpers/20210916-044145 git checkout eb031b7a8eac1f8c6f61fee94daa7fd43945ce96 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
In file included from <built-in>:4:
drivers/gpu/drm/i915/display/intel_hdcp.h:30:15: error: declaration of 'struct drm_atomic_state' will not be visible outside of this function [-Werror,-Wvisibility]
struct drm_atomic_state *state); ^ 1 error generated.
vim +30 drivers/gpu/drm/i915/display/intel_hdcp.h
25 26 int intel_hdcp_init(struct intel_connector *connector, 27 struct intel_digital_port *dig_port, 28 const struct intel_hdcp_shim *hdcp_shim); 29 int intel_hdcp_setup(struct drm_connector *drm_connector,
30 struct drm_atomic_state *state);
31 int intel_hdcp_load_keys(struct drm_connector *drm_connector); 32 bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port); 33 int intel_hdcp_capable(struct intel_connector *connector, bool *capable); 34 int intel_hdcp2_capable(struct drm_connector *drm_connector, bool *capable); 35 int intel_hdcp2_enable(struct drm_connector *drm_connector); 36 int intel_hdcp2_disable(struct drm_connector *drm_connector); 37 int intel_hdcp2_check_link(struct drm_connector *drm_connector); 38 int intel_hdcp1_store_receiver_info(struct drm_connector *drm_connector, 39 u32 *ksv, u32 status, u8 caps, 40 bool repeater_present); 41 int intel_hdcp1_read_an(struct drm_connector *drm_connector, 42 struct drm_hdcp_an *an); 43 int intel_hdcp1_enable_encryption(struct drm_connector *drm_connector); 44 int intel_hdcp1_wait_for_r0(struct drm_connector *drm_connector); 45 int intel_hdcp1_match_ri(struct drm_connector *drm_connector, u32 ri_prime); 46 int intel_hdcp1_post_encryption(struct drm_connector *drm_connector); 47 int intel_hdcp1_store_ksv_fifo(struct drm_connector *drm_connector, 48 u8 *ksv_fifo, u8 num_downstream, u8 *bstatus, 49 u32 *v_prime); 50 int intel_hdcp1_check_link(struct drm_connector *drm_connector); 51 int intel_hdcp1_disable(struct drm_connector *drm_connector); 52 void intel_hdcp_component_init(struct drm_i915_private *dev_priv); 53 void intel_hdcp_component_fini(struct drm_i915_private *dev_priv); 54 void intel_hdcp_cleanup(struct intel_connector *connector); 55 void intel_hdcp_handle_cp_irq(struct intel_connector *connector); 56
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org