Hello Inki,
On 03/28/2016 09:28 PM, Javier Martinez Canillas wrote:
Commit aeefb36832e5 ("drm/exynos: gsc: add device tree support and remove usage of static mappings") made the DRM_EXYNOS_GSC Kconfig symbol to only be selectable if the exynos-gsc V4L2 driver isn't enabled, since both use the same HW IP block.
But added the dependency as depends on !VIDEO_SAMSUNG_EXYNOS_GSC which is not correct since Kconfig expressions are not boolean but tristate. So it will only evaluate to 'n' if VIDEO_SAMSUNG_EXYNOS_GSC=y but will evaluate to 'm' if VIDEO_SAMSUNG_S5P_G2D=m.
This means that both the V4L2 and DRM drivers can be enabled if the former is enabled as a module, which is not what we want.
Signed-off-by: Javier Martinez Canillas javier@osg.samsung.com
I see that only patch 1/3 from this series was picked but according to the conversation with Seung-Woo [0] in the cover letter, the GSC v4l2 and drm drivers don't support to be simultaneous enabled like is the case for FIMC.
So patch 3/3 is the only one of the series that should be dropped and this one picked as well.
[0]: https://lkml.org/lkml/2016/3/29/7
Best regards,