On Wed, Jan 17, 2018 at 11:55:23PM +0200, Laurent Pinchart wrote:
Hello,
Hi Laurent,
This patch series removes a few cargo-cult constructs from a set of atomic drivers.
Patches 01/12 and 02/12 remove the unneeded .mode_set() and .mode_set_base() CRTC handlers from the arc and atmel-hlcdc drivers.
Patches 03/12 to 12/12 then remove the use of drm_plane_helper_disable() from the plane .destroy() handlers of atomic drivers, replacing them with the use of drm_atomic_helper_shutdown() at removal time. Interleaved there are patches 04/12 and 06/12 that remove unnecessary cleanups in error paths, and patch 09/12 that adds missing cleanup.
Thanks for the cleanup!
All this has been compile-tested only.
And I was trying to test the patches today but I've made the foolish decision to update the firmware on my Juno board first :( I hope to finish the testing tomorrow.
Laurent Pinchart (12): drm: arc: Don't set CRTC .mode_set and .mode_set_base handlers drm: atmel-hlcdc: Don't set CRTC .mode_set and .mode_set_base handlers drm: arc: Use drm_atomic_helper_shutdown() to disable planes on removal drm: arm: hdlcd: Don't destroy plane manually in hdlcd_setup_crtc() drm: arm: hdlcd: Use drm_atomic_helper_shutdown() to disable planes on removal drm: arm: malidp: Don't destroy planes manually in error handlers drm: arm: malidp: Use drm_atomic_helper_shutdown() to disable planes on removal drm: msm: Use drm_atomic_helper_shutdown() to disable planes on removal drm: sti: Cleanup KMS objects on removal drm: sti: Use drm_atomic_helper_shutdown() to disable planes on removal drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal drm: zte: Use drm_atomic_helper_shutdown() to disable planes on removal
Anyway, for the hdlcd and malidp patches in the series:
Acked-by: Liviu Dudau liviu.dudau@arm.com
If you need me to get the driver patches into my trees let me know.
Best regards, Liviu
drivers/gpu/drm/arc/arcpgu_crtc.c | 12 ++---------- drivers/gpu/drm/arc/arcpgu_drv.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c | 12 ++---------- drivers/gpu/drm/arm/hdlcd_drv.c | 1 + drivers/gpu/drm/arm/malidp_crtc.c | 10 ++-------- drivers/gpu/drm/arm/malidp_drv.c | 2 +- drivers/gpu/drm/arm/malidp_drv.h | 1 - drivers/gpu/drm/arm/malidp_planes.c | 17 +---------------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 -- drivers/gpu/drm/msm/Kconfig | 1 - drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 1 - drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 1 - drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/sti/sti_cursor.c | 10 +--------- drivers/gpu/drm/sti/sti_drv.c | 2 ++ drivers/gpu/drm/sti/sti_gdp.c | 10 +--------- drivers/gpu/drm/sti/sti_hqvdp.c | 10 +--------- drivers/gpu/drm/vc4/Kconfig | 1 - drivers/gpu/drm/vc4/vc4_drv.c | 3 +++ drivers/gpu/drm/vc4/vc4_plane.c | 8 +------- drivers/gpu/drm/zte/Kconfig | 2 +- drivers/gpu/drm/zte/zx_drm_drv.c | 1 + drivers/gpu/drm/zte/zx_plane.c | 8 +------- 23 files changed, 23 insertions(+), 94 deletions(-)
-- Regards,
Laurent Pinchart