On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
Hi Boris,
Thank you for the patch.
On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote:
One of the last remaining objects to not have its atomic state.
This is being motivated by our attempt to support runtime bus-format negotiation between elements of the bridge chain. This patch just paves the road for such a feature by adding a new drm_bridge_state object inheriting from drm_private_obj so we can re-use some of the existing state initialization/tracking logic.
Signed-off-by: Boris Brezillon boris.brezillon@collabora.com Reviewed-by: Neil Armstrong narmstrong@baylibre.com
Changes in v4:
- Fix the doc
- Kill default helpers (inlined)
I liked the default helpers, inlining their content makes the code more difficult to follow in my opinion.
I'll go back to this approach then. Should I keep the original helper names even though they're not globally visible (and should probably never be)?