On Do, 2020-02-27 at 15:02 +0300, Wambui Karuga wrote:
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_file only returns 0, and there is no need to check the return value. This change therefore removes the check and error handling in etnaviv_debugfs_init() and also makes the function return void.
Signed-off-by: Wambui Karuga wambui.karugax@gmail.com
Reviewed-by: Lucas Stach l.stach@pengutronix.de
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 6b43c1c94e8f..a39735316ca5 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -231,21 +231,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = { {"ring", show_each_gpu, 0, etnaviv_ring_show}, };
-static int etnaviv_debugfs_init(struct drm_minor *minor) +static void etnaviv_debugfs_init(struct drm_minor *minor) {
- struct drm_device *dev = minor->dev;
- int ret;
- ret = drm_debugfs_create_files(etnaviv_debugfs_list,
ARRAY_SIZE(etnaviv_debugfs_list),minor->debugfs_root, minor);- if (ret) {
dev_err(dev->dev, "could not install etnaviv_debugfs_list\n");return ret;- }
- return ret;
- drm_debugfs_create_files(etnaviv_debugfs_list,
ARRAY_SIZE(etnaviv_debugfs_list),minor->debugfs_root, minor);} #endif