On Mon, Dec 05, 2016 at 12:33:28PM -0800, Manasi Navare wrote:
On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote:
Hm, tiny new bikeshed: I'd drop the _property postfix here. The function name is already really long as-is, and the fact that the link status is exposed as a property is kinda irrelevant for kernel driver writers. But up to you. -Daniel
I decided to name it as drm_mode_connector_set_link_status_property() looking at names of other set_property functions like drm_mode_connector_update_edid_property() or drm_mode_connector_set_path_property(). Thats why I think it makes sense to append it with property just to be consistent.
Yeah it's fine either way, maybe we could just drop _property from all of them. Really doesn't add much, but these long function names make reasonable code layout a pain. Anyway, nothing that must be done here, agreed. -Daniel