Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel

On Sun, Aug 11, 2019 at 10:56 AM Sam Ravnborg sam@ravnborg.org wrote:

Hi Laurent.

My meta-schemas foo is very limited, but I noticed a few things. Hopefully Rob finds time soon to review.

    Sam

On Sun, Aug 11, 2019 at 02:10:42AM +0300, Laurent Pinchart wrote:

...

The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB parallel data interface and an SPI control interface.

Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

Changes since v1:

• Convert to YAML

---

.../display/panel/nec,nl8048hl11.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml new file mode 100644 index 000000000000..cc3d40975828 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: NEC NL8048HL11 4.1" WVGA TFT LCD panel

+description:

• The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
• data interface and an SPI control interface.

+maintainers:

• • Laurent Pinchart laurent.pinchart@ideasonboard.com

+allOf:

• • $ref: panel-common.yaml#

I *think* we are missing a reference to spi-controller.yaml here.

No, because this is a SPI slave, not a SPI controller. The example does need a 'spi' parent node and then spi-controller.yaml will get applied to the example.

Rob