Re: [PATCH 2/4] drm/bochs: Implement struct drm_mode_config_funcs.mode_valid

On Mon, Feb 03, 2020 at 09:35:54AM +0100, Thomas Zimmermann wrote:

Hi Gerd

Am 03.02.20 um 07:47 schrieb Gerd Hoffmann:

...

On Sat, Feb 01, 2020 at 01:27:42PM +0100, Thomas Zimmermann wrote:

...

The implementation of struct drm_mode_config_funcs.mode_valid verifies that enough video memory is available for a given display mode.

There is bochs_connector_mode_valid() doing the same check, you can drop it when hooking up drm_vram_helper_mode_valid.

Oh, didn't see it. That's more duplicated code to remove. :)

There's a helpful comment in bochs_connector_mode_valid(). Where shall I move it?

I'd say it can be dropped. linux kernel source code isn't exactly the place where you expect documentation about configuring qemu ;)

cheers, Gerd