1 Mar
2013
1 Mar
'13
1:45 p.m.
On 14:43-20130301, Ville Syrjälä wrote:
On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote:
[..]
@@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid);
#define DDC_SEGMENT_ADDR 0x30 /**
- Get EDID information via I2C.
- \param adapter : i2c device adaptor
- \param buf : EDID data buffer to be filled
- \param len : EDID data buffer length
- \return 0 on success or -1 on failure.
- drm_do_probe_ddc_edid() - Get EDID information via I2C.
- @adapter: i2c device adaptor
nit: adapter vs. adaptor
Thanks for catching it.
- @buf: EDID data buffer to be filled
- @block: EDID block to get
- @len: EDID data buffer length
- Try to fetch EDID information by calling i2c driver function.
*/
- Return 0 on success or -1 on failure.
static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: }
/**
- Probe DDC presence.
- drm_probe_ddc() - Probe DDC presence
- @adapter: i2c device adaptor
- \param adapter : i2c device adaptor
- \return 1 on success
*/
- returns 1 on success
bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b)
/**
- drm_mode_std - convert standard mode info (width, height, refresh) into mode
- @connector: connector corresponding to the HDMI/DP sink
EDID isn't limited to HDMI/DP.
[..]
/**
- drm_rgb_quant_range_selectable - is RGB quantization range selectable?
- @edid: EDID data
nit: Different description for the same thing between this and the previous hunk.
agreed. How about just EDID data?
--
Regards,
Nishanth Menon