Hi Doug
On 4/22/2022 9:10 AM, Doug Anderson wrote:
Hi,
On Fri, Apr 22, 2022 at 9:05 AM Abhinav Kumar quic_abhinavk@quicinc.com wrote:
Hi Doug
For the lockdep error, the splat looks similar to what kuogee fixed recently.
Can you please check if below patch is present in your tree?
Indeed I did have that in my tree already, but the lockdep splat is still there. I think the problem is that we're now calling dp_hpd_plug_handle() directly in dp_bridge_enable()
-Doug
Yes, now i understood this particular issue better and not sure how this wasn't caught. Perhaps some difference in the USE flags. Sankeerth didnt have lockdebug and thats why didnt hit this.
I have discussed with kuogee about why this change is needed and why this wasnt being done in get_modes().
It seems like originally, this was done for a quirk in the DP compliance equipment that it did not publish the fail safe mode ( even though some other modes were present ). Typically, any sink (as long as EDID read went through ) adds the 640x480 fail safe mode.
We could have done it in get_modes() even earlier but not sure how it was missed or was there some other reason.
Nonetheless, kuogee will post the change to move this to get_modes() shortly.
Thanks
Abhinav