Re: [PATCH 5/9] drm/i915: Enable i915 perf stream for Haswell OA unit

On Wed, Apr 20, 2016 at 03:23:10PM +0100, Robert Bragg wrote:

+static int i915_oa_read(struct i915_perf_stream *stream,

• 	struct i915_perf_read_state *read_state)
  

+{

• struct drm_i915_private *dev_priv = stream->dev_priv;
• return dev_priv->perf.oa.ops.read(stream, read_state);

+}

• stream->destroy = i915_oa_stream_destroy;
• stream->enable = i915_oa_stream_enable;
• stream->disable = i915_oa_stream_disable;
• stream->can_read = i915_oa_can_read;
• stream->wait_unlocked = i915_oa_wait_unlocked;
• stream->poll_wait = i915_oa_poll_wait;
• stream->read = i915_oa_read;

Why aren't these a const ops table? -Chris