Hi Pankaj,
On Mon, 2 Mar 2020 at 16:33, Pankaj Bharadiya pankaj.laxminarayan.bharadiya@intel.com wrote:
This series addresses below drm_fb_helper tasks from Documentation/gpu/todo.rst.
The max connector argument for drm_fb_helper_init() isn't used anymore and can be removed.
The helper doesn't keep an array of connectors anymore so these can be removed: drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
Changes since v1:
- Squashed warning fixes into the patch that introduced the warnings (into 5/7) (Laurent)
- Fixed reflow in in 9/9 (Laurent)
For the future, include the changelog in the respective patches. This makes it easier for reviewers... Plus you're already changing the commit - might as well mention what/why :-)
Also do include the R-B, Acked-by, other tags accumulated up-to that point, when sending new revision.
That said, if you're interested in further cleaning this up, one can cleanup the drm_dp_mst_topology_cbs hooks. In particular ::register_connector is identical across the board - create a helper function using it directly in core, killing the hook.
While for ::destroy_connector - there's some amdgpu specific code in there... which I'm not sure if it should stay or not. To be on the save side - create a helper which will be called for drivers where the hook is !=NULL (aka everyone but amdgpu).
HTH Emil