Hi Steffen,
On Friday 05 October 2012 17:51:21 Steffen Trumtrar wrote:
On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote:
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote:
Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings
+++ b/drivers/of/of_videomode.c
+int videomode_from_timing(struct display_timings *disp, struct videomode *vm,
- st = display_timings_get(disp, index);
- if (!st) {
It's a little odd to leave a blank line between those two lines.
Hm, well okay. That can be remedied
Only half of the code in this file seems OF-related; the routines to convert a timing to a videomode or drm display mode seem like they'd be useful outside device tree, so I wonder if putting them into of_videomode.c is the correct thing to do. Still, it's probably not a big deal.
I am not sure, what the appropriate way to do this is. I can split it up (again).
I think it would make sense to move them to their respective subsystems.