Hi Sam,
On Mon, Jun 21, 2021 at 08:49:53PM +0200, Sam Ravnborg wrote:
On Mon, Jun 21, 2021 at 03:55:13PM +0300, Laurent Pinchart wrote:
Hello,
This patch series is based on top of "[PATCH] drm/bridge: ti-sn65dsi83: Replace connector format patching with atomic_get_input_bus_fmts". It completes the transition to atomic operations in the ti-sn65dsi83 driver. The main reason for this change is patch 4/5 that fixes a few issues in the driver (see the patch's commit message for details), but overall it also brings the driver to the most recent API which is nice in itself.
Laurent Pinchart (5): drm: bridge: ti-sn65dsi83: Move LVDS format selection to .mode_set() drm: bridge: ti-sn65dsi83: Pass mode explicitly to helper functions drm: bridge: ti-sn65dsi83: Switch to atomic operations drm: bridge: ti-sn65dsi83: Retrieve output format from bridge state drm: bridge: ti-sn65dsi83: Retrieve the display mode from the state
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 166 +++++++++++++------------- 1 file changed, 82 insertions(+), 84 deletions(-)
I have browsed the series and it all looked good. Acked-by: Sam Ravnborg sam@ravnborg.org
on them all.
It is news to me that the atomic ops are the way to go - but then I have been off-line for a while so no suprise or maybe I just missed it before.
They're not mandatory as such, but they give us access to the atomic state, which is sometimes required. Overall I think it would be nice to move to the atomic operations and drop the legacy ones, to avoid maintaining two sets of operations. It will take time :-)
It would be good if the comments in drm_bridge.h could point out what is deprecated, so we know what to avoid in new and updated bridge drivers. But this is all un-related to this series.
It's a good point. Would you like to submit a patch, or should I do so ?