-----Original Message----- From: Sean Paul [mailto:seanpaul@chromium.org] Sent: Thursday, October 17, 2013 4:27 AM To: dri-devel@lists.freedesktop.org; inki.dae@samsung.com Cc: airlied@linux.ie; tomasz.figa@gmail.com; marcheu@chromium.org; Sean Paul Subject: [PATCH v2 12/26] drm/exynos: Split manager/display/subdrv
This patch splits display and manager from subdrv. The result is that crtc functions can directly call into manager callbacks and encoder functions can directly call into display callbacks. This will allow us to remove the exynos_drm_hdmi shim and support mixer/hdmi & fimd/dp with common code.
Signed-off-by: Sean Paul seanpaul@chromium.org
Changes in v2:
- Pass display into display_ops instead of context
Sorry but it seems like more reasonable to pass device object into display_ops and manager_ops.
I'm not sure but display_ops could be implemented in other framework based driver such as CDF based lcd panel driver. So if you pass display - it's specific to exynos drm framework - into display_ops, the other framework based driver should include specific exynos drm header.
And another one, the patch 6 passes manager object to manager_ops, and for this, you made the manager object to be set to driver data; platform_set_drvdata(pdev, &manager). That isn't reasonable. Generally, driver_data would point to device driver's context object.
Thanks, Inki Dae