On Tue, Mar 15, 2016 at 02:39:58PM +0100, Lukas Wunner wrote:
Hi Mika,
On Mon, Mar 14, 2016 at 11:43:35AM +0200, Mika Westerberg wrote:
On Mon, Mar 14, 2016 at 12:19:14PM +1000, Dave Airlie wrote:
On 11 March 2016 at 23:45, Rafael J. Wysocki rjw@rjwysocki.net wrote:
On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote:
On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote:
> It doesn't seem to do any runtime PM, > I do wonder if pcieport should be doing it's own runtime PM handling, > but that is a > larger task than I'm thinking to tackle here.
PCIe ports don't do PM - yet. Mika has posted a series of patches to implement that, however, that are waiting for comments now:
https://patchwork.kernel.org/patch/8453311/ https://patchwork.kernel.org/patch/8453381/ https://patchwork.kernel.org/patch/8453391/ https://patchwork.kernel.org/patch/8453411/ https://patchwork.kernel.org/patch/8453371/ https://patchwork.kernel.org/patch/8453351/
If a pciehp port is runtime suspended and pciehp_poll_mode is enabled, the poll timer needs to be disabled and later reenabled on runtime resume.
If we disable the timer then we can't detect when a new device is connected to the port.
I think in this case it might be better not to enable runtime PM for the port at all.