Hi, Enric:
Enric Balletbo i Serra enric.balletbo@collabora.com 於 2020年4月17日 週五 下午11:06寫道：
Use the drm_bridge_connector helper to create a connector for pipelines that use drm_bridge. This allows splitting connector operations across multiple bridges when necessary, instead of having the last bridge in the chain creating the connector and handling all connector operations internally.
Signed-off-by: Enric Balletbo i Serra enric.balletbo@collabora.com
Changes in v3:
- Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart)
Changes in v2: None
drivers/gpu/drm/mediatek/mtk_dsi.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 157097c63b23..85f76b01ae4d 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -17,6 +17,7 @@
#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_bridge_connector.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h> #include <drm/drm_panel.h> @@ -183,6 +184,7 @@ struct mtk_dsi { struct drm_encoder encoder; struct drm_bridge bridge; struct drm_bridge *next_bridge;
struct drm_connector *connector; struct phy *phy; void __iomem *regs;@@ -977,10 +979,19 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) */ dsi->encoder.possible_crtcs = 1;
ret = drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL, 0);
ret = drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL,DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) goto err_cleanup_encoder;dsi->connector = drm_bridge_connector_init(drm, &dsi->encoder);if (IS_ERR(dsi->connector)) {DRM_ERROR("Unable to create bridge connector\n");ret = PTR_ERR(dsi->connector);goto err_cleanup_encoder;}drm_connector_attach_encoder(dsi->connector, &dsi->encoder);
I'm not very clear about how brige-connector works, but why connector does not attach to panel?
Regards, Chun-Kuang.
return 0;err_cleanup_encoder:
2.25.1